Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

add tags to release.yml #4

Merged
merged 27 commits into from
Feb 1, 2023
Merged

add tags to release.yml #4

merged 27 commits into from
Feb 1, 2023

Conversation

itsmostafa
Copy link
Contributor

@itsmostafa itsmostafa commented Jan 30, 2023 •
edited
Loading

fix: add tags to releases

🗣 Description

add .gorelease.yaml file

💭 Motivation and context

remove tags step to speed up development time

🧪 Testing

none as of yet

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@itsmostafa itsmostafa marked this pull request as ready for review January 30, 2023 20:50
izzy64
izzy64 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@izzy64 izzy64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsmostafa itsmostafa marked this pull request as draft January 30, 2023 20:57
@itsmostafa itsmostafa changed the title remove tags step in release.yml add tags to release.yml Jan 30, 2023
@itsmostafa itsmostafa force-pushed the feature/add-release-actions branch from 97d593a to 1d1c6d1 Compare January 30, 2023 22:39
@itsmostafa itsmostafa force-pushed the feature/add-release-actions branch from d957fbe to dfe2fd0 Compare January 31, 2023 00:21
@itsmostafa itsmostafa force-pushed the feature/add-release-actions branch 8 times, most recently from 59d082a to b4dd543 Compare January 31, 2023 01:44
@itsmostafa itsmostafa force-pushed the feature/add-release-actions branch from b4dd543 to fae4279 Compare January 31, 2023 01:51
@itsmostafa itsmostafa force-pushed the feature/add-release-actions branch 4 times, most recently from fc1310c to 64a7bae Compare January 31, 2023 23:41
@itsmostafa itsmostafa force-pushed the feature/add-release-actions branch from 64a7bae to c202607 Compare January 31, 2023 23:49
@itsmostafa itsmostafa force-pushed the feature/add-release-actions branch from 5e412b2 to 6724790 Compare February 1, 2023 04:41
@itsmostafa itsmostafa marked this pull request as ready for review February 1, 2023 04:57
@itsmostafa itsmostafa merged commit 7b1b5c6 into develop Feb 1, 2023
@itsmostafa itsmostafa deleted the feature/add-release-actions branch February 1, 2023 05:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@izzy64 izzy64 izzy64 approved these changes

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsmostafa @jsf9k @izzy64